Skip to content

chore: upgrade to new eslint and switch to flat config #36272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 24 commits into from
Dec 3, 2025
Merged

chore: upgrade to new eslint and switch to flat config #36272

mergify merged 24 commits into from
Dec 3, 2025

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Dec 2, 2025 •
edited
Loading

Centralize eslint config in a new package, @aws-cdk/eslint-config as well because it was duplicated too much.

Addresses linting/compilation problems that had gone unnoticed because of nonstandard package configs.

  • Since the version of @stylistic/eslint-plugin that supports flat config forces a move to ESM. Since Node 18 doesn't yet support require()ing ESM modules and since config loading needs to be synchronous, our config has to run as ESM.
  • Rename .eslintrc.js -> eslint.config.mjs everywhere for the new flat config (and update .gitignore and .npmignore at the same time)
  • Introduce @aws-cdk/eslint-config to hold a centralized config for all packages in the monorepo.
  • Found some .bak files that seem like they're just hanging out.
  • Update all packages with eslint --fix to the new sets of rules.
  • Custom resource handler tests were not being type checked and had a bunch of issues that needed to be fixed.
  • quote-props -> @stylistic/quote-props
  • Bulk suppressions for the Error rule in dedicated files, because the eslint tool doesn't allow adding suppression comments in bulk.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team December 2, 2025 13:22
@aws-cdk-automation aws-cdk-automation requested a review from a team December 2, 2025 13:22
@github-actions github-actions bot added the p2 label Dec 2, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 2, 2025
@pahud pahud mentioned this pull request Dec 2, 2025
Open
@rix0rrr rix0rrr requested a review from a team as a code owner December 2, 2025 15:58
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 2, 2025
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@pahud pahud mentioned this pull request Dec 2, 2025
Open
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 3, 2025 09:09

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025 •
edited
Loading

Merge Queue Status Beta

🚫 The pull request has left the queue (rule: default-squash)

This pull request spent 9 minutes 43 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

merge conflict between base and head

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 3, 2025
@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025 •
edited
Loading

Merge Queue Status Beta

✅ The pull request has been merged

This pull request spent 6 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge

@mergify
Copy link
Contributor

mergify bot commented Dec 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 617bcba into main Dec 3, 2025
20 of 21 checks passed
@mergify mergify bot deleted the huijbers/flat-eslint branch December 3, 2025 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vishaalmehrishi vishaalmehrishi vishaalmehrishi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/analytics-metadata-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rix0rrr @vishaalmehrishi @aws-cdk-automation